New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplier border shader for solid borders. #3011

Merged
merged 2 commits into from Sep 5, 2018

Conversation

Projects
None yet
4 participants
@djg
Contributor

djg commented Sep 3, 2018

This fixes #3003


This change is Reviewable

@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583

gw3583 Sep 4, 2018

Contributor

@djg Could you do a try run and paste the link?

Contributor

gw3583 commented Sep 4, 2018

@djg Could you do a try run and paste the link?

@djg

This comment has been minimized.

Show comment
Hide comment
@djg

djg Sep 4, 2018

Contributor

@gw3583 I can. I think. :-)

Contributor

djg commented Sep 4, 2018

@gw3583 I can. I think. :-)

@djg

This comment has been minimized.

Show comment
Hide comment
Contributor

djg commented Sep 4, 2018

@kvark

This comment has been minimized.

Show comment
Hide comment
@kvark

kvark Sep 4, 2018

Member

@djg there is a bunch of unexpected passes (🎉 ), and all the failures are marked as intermittent.

Member

kvark commented Sep 4, 2018

@djg there is a bunch of unexpected passes (🎉 ), and all the failures are marked as intermittent.

Show resolved Hide resolved webrender/res/cs_border_solid.glsl
Show resolved Hide resolved webrender/src/tiling.rs
Show resolved Hide resolved webrender/src/tiling.rs
@djg

This comment has been minimized.

Show comment
Hide comment
@djg

djg Sep 4, 2018

Contributor

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a6cd6951e21d025d791e7aeef0ef7897c55649a&selectedJob=197318957 is just the changes from this patch and not all of webrender. The transform-3d reftest failure goes away.

Contributor

djg commented Sep 4, 2018

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a6cd6951e21d025d791e7aeef0ef7897c55649a&selectedJob=197318957 is just the changes from this patch and not all of webrender. The transform-3d reftest failure goes away.

@kvark

kvark approved these changes Sep 5, 2018

@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583

gw3583 Sep 5, 2018

Contributor

@bors-servo r=kvark

Contributor

gw3583 commented Sep 5, 2018

@bors-servo r=kvark

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 5, 2018

Contributor

📌 Commit 133026f has been approved by kvark

Contributor

bors-servo commented Sep 5, 2018

📌 Commit 133026f has been approved by kvark

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 5, 2018

Contributor

⌛️ Testing commit 133026f with merge 226d23e...

Contributor

bors-servo commented Sep 5, 2018

⌛️ Testing commit 133026f with merge 226d23e...

bors-servo added a commit that referenced this pull request Sep 5, 2018

Auto merge of #3011 - djg:split-cs-border-segment, r=kvark
Add simplier border shader for solid borders.

This fixes #3003

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3011)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 5, 2018

Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 226d23e to master...

Contributor

bors-servo commented Sep 5, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 226d23e to master...

@bors-servo bors-servo merged commit 133026f into servo:master Sep 5, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

emilio added a commit that referenced this pull request Sep 7, 2018

renderer: Fix border profiling.
Was broken by #3011.

Also while at it, avoid setting and unsetting blend modes unnecessarily.

bors-servo added a commit that referenced this pull request Sep 7, 2018

Auto merge of #3032 - servo:border-profile, r=kvark
renderer: Fix border profiling.

Was broken by #3011.

Also while at it, avoid setting and unsetting blend modes unnecessarily.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3032)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment