Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flat varying #3012

Closed
wants to merge 1 commit into from
Closed

Remove flat varying #3012

wants to merge 1 commit into from

Conversation

@djg
Copy link
Contributor

djg commented Sep 4, 2018 •
edited by larsbergstrom

This addresses Issue #3004

This change is Reviewable
@gw3583
Copy link
Collaborator

gw3583 commented Sep 4, 2018

Nice! Could you kick off a try run?
@djg
Copy link
Contributor Author

djg commented Sep 4, 2018

Nice! Could you kick off a try run?

Yup. Just sorting out local changes.
@djg djg force-pushed the djg:remove-flat-varying branch from b09338f to fb17ab8 Sep 5, 2018
@djg
add ANGLE specific removals of flat varying
Loading status checks…
4a6c020
@djg djg force-pushed the djg:remove-flat-varying branch from fb17ab8 to 4a6c020 Sep 6, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2018

☔ The latest upstream changes (presumably #3030) made this pull request unmergeable. Please resolve the merge conflicts.
@djg
Copy link
Contributor Author

djg commented Sep 14, 2018

Discussion with @gw3583, we agreed that it was better to keep flat varying because it's a win for fragment shader performance.
@djg djg closed this Sep 14, 2018
@djg djg deleted the djg:remove-flat-varying branch Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@djg @gw3583 @bors-servo
You can’t perform that action at this time.