Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use unsigned integer division in shaders #3014

Merged
merged 1 commit into from Sep 5, 2018
Merged

Consistently use unsigned integer division in shaders #3014

merged 1 commit into from Sep 5, 2018

Conversation

@kvark
Copy link
Member

kvark commented Sep 4, 2018 •
edited by larsbergstrom

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1443747

This change is Reviewable
@kvark
Consistently use unsigned integer division in shaders
Loading status checks…
211e3d6
@kvark kvark requested a review from gw3583 Sep 4, 2018
@nical
nical approved these changes Sep 4, 2018
View changes
Copy link
Collaborator

nical left a comment

Looks good to me.
@kvark
Copy link
Member Author

kvark commented Sep 4, 2018

Thanks for the quick review!
Waiting for a try in https://treeherder.mozilla.org/#/jobs?repo=try&revision=b91f07ab2d18bc453b9bf8ced90ea8bd5492bffd
@kvark
Copy link
Member Author

kvark commented Sep 4, 2018

Try is green.
@bors-servo r=nical
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

📌 Commit 211e3d6 has been approved by nical
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2018

⌛ Testing commit 211e3d6 with merge 4fef6ca...
bors-servo added a commit that referenced this pull request Sep 4, 2018
@bors-servo
Auto merge of #3014 - kvark:shader-uint, r=nical
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4fef6ca 
Consistently use unsigned integer division in shaders

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1443747

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3014)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 4fef6ca to master...
@bors-servo bors-servo merged commit 211e3d6 into servo:master Sep 5, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark kvark deleted the kvark:shader-uint branch Sep 5, 2018
@kvark kvark mentioned this pull request Sep 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical

@gw3583 gw3583

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kvark @bors-servo @nical
You can’t perform that action at this time.