New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use unsigned integer division in shaders #3014

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
3 participants
@kvark
Member

kvark commented Sep 4, 2018

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1443747


This change is Reviewable

@kvark kvark requested a review from gw3583 Sep 4, 2018

@nical

nical approved these changes Sep 4, 2018

Looks good to me.

@kvark

This comment has been minimized.

Show comment
Hide comment
@kvark
Member

kvark commented Sep 4, 2018

@kvark

This comment has been minimized.

Show comment
Hide comment
@kvark

kvark Sep 4, 2018

Member

Try is green.
@bors-servo r=nical

Member

kvark commented Sep 4, 2018

Try is green.
@bors-servo r=nical

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 4, 2018

Contributor

📌 Commit 211e3d6 has been approved by nical

Contributor

bors-servo commented Sep 4, 2018

📌 Commit 211e3d6 has been approved by nical

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 4, 2018

Contributor

⌛️ Testing commit 211e3d6 with merge 4fef6ca...

Contributor

bors-servo commented Sep 4, 2018

⌛️ Testing commit 211e3d6 with merge 4fef6ca...

bors-servo added a commit that referenced this pull request Sep 4, 2018

Auto merge of #3014 - kvark:shader-uint, r=nical
Consistently use unsigned integer division in shaders

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1443747

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3014)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 5, 2018

Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 4fef6ca to master...

Contributor

bors-servo commented Sep 5, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 4fef6ca to master...

@bors-servo bors-servo merged commit 211e3d6 into servo:master Sep 5, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@kvark kvark deleted the kvark:shader-uint branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment