New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the border shader to avoid driver warnings #3024

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
3 participants
@kvark
Member

kvark commented Sep 5, 2018

A blind attempt to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1443747#c11
WIP unless we are fine with the changes even if they don't fix the issue :) edit: confirmed to fix the issue

Particular fixes:

  • avoid returns from switch cases
  • avoid dynamic vec4 indexing
  • initialize more data before the switch statements

Pending try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9229af3cf0f15e69e8265e923a2347c84a436f21


This change is Reviewable

@kvark kvark requested a review from gw3583 Sep 5, 2018

kvark added some commits Sep 5, 2018

Refactor the border shader to avoid driver warnings:
  - avoid returns from switch cases
  - avoid dynamic vec4 indexing
  - initialize more data before the switch statements

@kvark kvark changed the title from [WIP] Refactor the border shader to avoid driver warnings to Refactor the border shader to avoid driver warnings Sep 6, 2018

@kvark

This comment has been minimized.

Show comment
Hide comment
@kvark

kvark Sep 6, 2018

Member

Added one more commit, launched a new try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea08bd760ce87efeab926cbbac69ace7566f2910
This should be ready to land (if try is green).

Member

kvark commented Sep 6, 2018

Added one more commit, launched a new try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea08bd760ce87efeab926cbbac69ace7566f2910
This should be ready to land (if try is green).

@kvark

This comment has been minimized.

Show comment
Hide comment
@kvark

kvark Sep 7, 2018

Member

@gw3583 failures in try look to all be intermittent. r? when you are done with local space rasterization :)

Member

kvark commented Sep 7, 2018

@gw3583 failures in try look to all be intermittent. r? when you are done with local space rasterization :)

@gw3583

gw3583 approved these changes Sep 7, 2018

Nice!

@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583

gw3583 Sep 7, 2018

Contributor
Contributor

gw3583 commented Sep 7, 2018

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 7, 2018

Contributor

📌 Commit 8ff3fa6 has been approved by gw3583

Contributor

bors-servo commented Sep 7, 2018

📌 Commit 8ff3fa6 has been approved by gw3583

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 7, 2018

Contributor

⌛️ Testing commit 8ff3fa6 with merge 59656aa...

Contributor

bors-servo commented Sep 7, 2018

⌛️ Testing commit 8ff3fa6 with merge 59656aa...

bors-servo added a commit that referenced this pull request Sep 7, 2018

Auto merge of #3024 - kvark:border-shader, r=gw3583
Refactor the border shader to avoid driver warnings

A blind attempt to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1443747#c11
~~WIP unless we are fine with the changes even if they don't fix the issue :)~~ edit: confirmed to fix the issue

Particular fixes:
  - avoid returns from switch cases
  - avoid dynamic vec4 indexing
  - initialize more data before the switch statements

~~Pending try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9229af3cf0f15e69e8265e923a2347c84a436f21~~

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3024)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 7, 2018

Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 59656aa to master...

Contributor

bors-servo commented Sep 7, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 59656aa to master...

@bors-servo bors-servo merged commit 8ff3fa6 into servo:master Sep 7, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@kvark kvark deleted the kvark:border-shader branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment