Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix twitter login crash. #303
Conversation
| }); | ||
|
|
||
| match location { | ||
| Some(location) => { |
This comment has been minimized.
This comment has been minimized.
pcwalton
Jun 30, 2016
Collaborator
nit: How about if let Some(location) = location { ... }? Since there's a return at the end, this should be equivalent, and then you can eliminate lots of rightward drift.
| assert!(allocation_size.width < max_texture_size()); | ||
| assert!(allocation_size.height < max_texture_size()); | ||
|
|
||
| loop { |
This comment has been minimized.
This comment has been minimized.
pcwalton
Jun 30, 2016
Collaborator
nit: I'd add a comment saying that you're looping to find a spot for the allocation, growing or adding pages as necessary.
| if item.texture_id == last_page.texture_id { | ||
| item.texture_size = Size2D::new(texture_size, texture_size); | ||
| } | ||
| }); |
This comment has been minimized.
This comment has been minimized.
pcwalton
Jun 30, 2016
Collaborator
nit: you could add continue here and then eliminate even more rightward drift by removing the else clause :)
This allows texture allocation to try multiple times, growing or adding texture pages as required.
|
@bors-servo r=pcwalton |
|
|
metajack
commented
Jun 30, 2016
|
Will this fix the box shadow thing on Windows too? On Wed, Jun 29, 2016 at 6:39 PM, bors-servo notifications@github.com
|
|
@metajack You mean where it asserts about not getting a standalone alloc? Yes, it should fix that. |
Fix twitter login crash. This allows texture allocation to try multiple times, growing or adding texture pages as required.
glennw commentedJun 30, 2016
This allows texture allocation to try multiple times, growing or adding texture pages as required.