New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic recording support for loaded captures #3038

Merged
merged 1 commit into from Sep 11, 2018

Conversation

Projects
None yet
3 participants
@kvark
Member

kvark commented Sep 10, 2018

Fixes #2583 (more follow-up is expected though for correctness)

This change makes the capture infrastructure play better with the display-list-based recording. It produces a fake SetDisplayList message to be recorded based on the (already) loaded scene. Result isn't always consumable by the YAML reader (there are correctness issues, and I bet the YAML reading-writing loop isn't sinless either, given that it was never tested on big scenes, typically produced by capturing from Gecko). Here is the basic example replayed from YAML:
wrench-yaml-from-capture

YAML is at least always generated, and it gives an easier workflow for developers trying to reproduce a captured bug in a YAML reftest.


This change is Reviewable

@kvark kvark requested a review from jrmuizel Sep 10, 2018

@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583
Contributor

gw3583 commented Sep 10, 2018

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 10, 2018

Contributor

📌 Commit 34e765b has been approved by gw3583

Contributor

bors-servo commented Sep 10, 2018

📌 Commit 34e765b has been approved by gw3583

@gw3583

This comment has been minimized.

Show comment
Hide comment
@gw3583

gw3583 Sep 11, 2018

Contributor

@bors-servo retry

Contributor

gw3583 commented Sep 11, 2018

@bors-servo retry

@gw3583 gw3583 closed this Sep 11, 2018

@gw3583 gw3583 reopened this Sep 11, 2018

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 11, 2018

Contributor

⌛️ Testing commit 34e765b with merge 525786a...

Contributor

bors-servo commented Sep 11, 2018

⌛️ Testing commit 34e765b with merge 525786a...

bors-servo added a commit that referenced this pull request Sep 11, 2018

Auto merge of #3038 - kvark:capture-record, r=gw3583
Basic recording support for loaded captures

Fixes #2583 (more follow-up is expected though for correctness)

This change makes the capture infrastructure play better with the display-list-based recording. It produces a fake `SetDisplayList` message to be recorded based on the (already) loaded scene. Result isn't always consumable by the YAML reader (there are correctness issues, and I bet the YAML reading-writing loop isn't sinless either, given that it was never tested on big scenes, typically produced by capturing from Gecko). Here is the `basic` example replayed from YAML:
![wrench-yaml-from-capture](https://user-images.githubusercontent.com/107301/45302345-10f60500-b4e1-11e8-9e94-aa4c82b2cb7d.png)

YAML is at least always generated, and it gives an easier workflow for developers trying to reproduce a captured bug in a YAML reftest.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3038)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 11, 2018

Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 525786a to master...

Contributor

bors-servo commented Sep 11, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 525786a to master...

@bors-servo bors-servo merged commit 34e765b into servo:master Sep 11, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@kvark kvark deleted the kvark:capture-record branch Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment