Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmodified configuration lines to specify windows, linux, and mac #304
Conversation
|
Travis says that there are unclosed delimiters in the Cargo.toml file now. |
|
Nice work, Lana! I'm excited to see your first PR and sorry that everything has been so chaotic around here with the push to get the Servo Nightlies out this week. |
|
@alanamramjit Looks good - could you squash these two commits and then we'll get this merged? Thanks |
|
Lana, feel free to reach out to any of us if using git to squash changes goes awry for you. There are some tips here: But in general, one possible command that you're looking for is |
|
I think it did go awry :[ |
|
OK, try this locally:
In the
At that point, you can go back to the GitHub UI for https://github.com/servo/webrender and it should say that there is a potential PR to open from your repository. You can go ahead and do so, commenting with an "r? @larsbergstrom" and close this one. |
|
@larsbergstrom hm I tried fixing it this way and several other couple of ways but it's still trying to create a pull request with > 4 commits so I think I'm going to take the burn it with fire approach |
lanamorgan commentedJun 30, 2016
No description provided.