Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified configuration lines to specify windows, linux, and mac #304

Closed
wants to merge 4 commits into from

Conversation

@lanamorgan
Copy link
Contributor

lanamorgan commented Jun 30, 2016

No description provided.

@jdm
Copy link
Member

jdm commented Jun 30, 2016

Travis says that there are unclosed delimiters in the Cargo.toml file now.

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 2, 2016

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 2, 2016

Nice work, Lana! I'm excited to see your first PR and sorry that everything has been so chaotic around here with the push to get the Servo Nightlies out this week.

@glennw
Copy link
Member

glennw commented Jul 3, 2016

@alanamramjit Looks good - could you squash these two commits and then we'll get this merged? Thanks

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 4, 2016

Lana, feel free to reach out to any of us if using git to squash changes goes awry for you. There are some tips here:
https://github.com/servo/servo/wiki/Github-workflow

But in general, one possible command that you're looking for is git rebase -i HEAD~2.

@lanamorgan
Copy link
Contributor Author

lanamorgan commented Jul 5, 2016

I think it did go awry :[

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 5, 2016

OK, try this locally:

[larsberg@larsberg webrender]$ git checkout -b modify_config
Switched to a new branch 'modify_config'
[larsberg@larsberg webrender]$ git cherry-pick 9eede7b
[modify_config cf93178] modified configuration lines to specify windows, linux, and mac
 Author: lana <alanamramjit@gmail.com>
 Date: Thu Jun 30 12:26:49 2016 -0700
 2 files changed, 4 insertions(+), 4 deletions(-)
[larsberg@larsberg webrender]$ git cherry-pick 9d6bb0e
[modify_config 897d2b5] fixed parantheses
 Author: lana <alanamramjit@gmail.com>
 Date: Thu Jun 30 13:27:21 2016 -0700
 1 file changed, 3 insertions(+), 3 deletions(-)
[larsberg@larsberg webrender]$ git rebase -i HEAD~2
[detached HEAD 5a0d4fd] modified configuration lines to specify windows, linux, and mac
 Author: lana <alanamramjit@gmail.com>
 Date: Thu Jun 30 12:26:49 2016 -0700
 2 files changed, 4 insertions(+), 4 deletions(-)
Successfully rebased and updated refs/heads/modify_config.

In the git rebase command, it will open up an editor with the two commits you just cherry-pick'd. On the line with the second one, change the first word to "fixup", save and exit. At this point you can then push this branch up to your github repo. Change the larsberg below to whatever the name of your personal github repo is. You can get it by looking at the out put of git remote -v:

[larsberg@larsberg webrender]$ git push larsberg modify_config
Counting objects: 134, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (52/52), done.
Writing objects: 100% (134/134), 24.25 KiB | 0 bytes/s, done.
Total 134 (delta 99), reused 115 (delta 81)
To https://github.com/larsbergstrom/webrender
 * [new branch]      modify_config -> modify_config
[larsberg@larsberg webrender]$ 

At that point, you can go back to the GitHub UI for https://github.com/servo/webrender and it should say that there is a potential PR to open from your repository. You can go ahead and do so, commenting with an "r? @larsbergstrom" and close this one.

@lanamorgan
Copy link
Contributor Author

lanamorgan commented Jul 5, 2016

@larsbergstrom hm I tried fixing it this way and several other couple of ways but it's still trying to create a pull request with > 4 commits so I think I'm going to take the burn it with fire approach

@lanamorgan lanamorgan closed this Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.