Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid allocating clip tasks for clip rects in same coordinate system. #3041

Merged
merged 1 commit into from Sep 11, 2018

Conversation

@gw3583
Copy link
Collaborator

commented Sep 11, 2018

If a clip chain only ends up with clip rects that are from the
same coordinate system, there is no need to allocate a clip mask,
as the clip can be implemented via the local clip rect in the
primitive vertex shader.

This is an important optimization for reducing clip task
allocations on common pages (although they won't actually be
drawn into the clip mask anyway).


This change is Reviewable

If a clip chain only ends up with clip rects that are from the
same coordinate system, there is no need to allocate a clip mask,
as the clip can be implemented via the local clip rect in the
primitive vertex shader.

This is an important optimization for reducing clip task
allocations on common pages (although they won't actually be
drawn into the clip mask anyway).
@gw3583

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 11, 2018

@nical
nical approved these changes Sep 11, 2018
@kvark
kvark approved these changes Sep 11, 2018
@kvark

This comment has been minimized.

Copy link
Member

commented Sep 11, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2018

📌 Commit d923d28 has been approved by kvark

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2018

⌛️ Testing commit d923d28 with merge d5dcb33...

bors-servo added a commit that referenced this pull request Sep 11, 2018
Avoid allocating clip tasks for clip rects in same coordinate system.

If a clip chain only ends up with clip rects that are from the
same coordinate system, there is no need to allocate a clip mask,
as the clip can be implemented via the local clip rect in the
primitive vertex shader.

This is an important optimization for reducing clip task
allocations on common pages (although they won't actually be
drawn into the clip mask anyway).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3041)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing d5dcb33 to master...

@bors-servo bors-servo merged commit d923d28 into servo:master Sep 11, 2018
2 of 3 checks passed
2 of 3 checks passed
Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.