Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully avoid generating empty border segments #3049

Closed
wants to merge 1 commit into from

Conversation

@kvark
Copy link
Member

kvark commented Sep 12, 2018

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1489644
Also related to #2715 (comment)

The change makes us avoid doing meaningless work and then stumbling upon unexpected data. Good for both performance, stability, and the health of the users ;)


This change is Reviewable

@kvark kvark requested a review from gw3583 Sep 12, 2018
@kvark
Copy link
Member Author

kvark commented Sep 12, 2018

Try push has a few failures - https://treeherder.mozilla.org/#/jobs?repo=try&revision=20051aa2e74a650b578975000da243b5609813d3&selectedJob=198925969
Although this is with replacing the whole gfx/webrender as opposed to patching the working version.

@gw3583
Copy link
Collaborator

gw3583 commented Sep 12, 2018

Generally looks good - although at least some of those try failures do look to be border related, so I'll take a closer look once those are resolved.

@kvark
Copy link
Member Author

kvark commented Sep 12, 2018

Another try push that is carefully rebased on the current WR revision of Gecko: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c0469da6856e6d611d0fb15a4c112ad93ef1387

@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2018

The latest upstream changes (presumably #3054) made this pull request unmergeable. Please resolve the merge conflicts.

@emilio
Copy link
Member

emilio commented Sep 13, 2018

Closing for the same reason as #3056.

@emilio emilio closed this Sep 13, 2018
@kvark kvark deleted the kvark:border-checks branch Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.