Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border: Avoid generating empty segments. #3056

Closed
wants to merge 2 commits into from
Closed

border: Avoid generating empty segments. #3056

wants to merge 2 commits into from

Commits on Sep 13, 2018

  1. border: Get rid of BorderCornerClipSource. 

    Instead, just add functions to add the instances directly, avoiding the
intermediate allocation and deindenting a bunch of the code.

This should have no behavior change.
    @emilio
    emilio committed Sep 13, 2018
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    88353b7

  2. border: Avoid generating empty segments. 

    This is a bit less invasive and should do the job.

I've confirmed that all the negative sizes come from edges, when a huge radii
with radius > rect.size - cw_border.width - ccw_border.width.

Still we're creating a gazillion empty borders which are useless, so prevent
that too.
    @emilio
    emilio committed Sep 13, 2018
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    06f5dcb
You can’t perform that action at this time.