Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Speed up updating the hit-test tree" #3061

Merged
merged 4 commits into from Sep 14, 2018
Merged

Revert "Speed up updating the hit-test tree" #3061

merged 4 commits into from Sep 14, 2018

Conversation

@kvark
Copy link
Member

kvark commented Sep 14, 2018 •
edited by larsbergstrom

This PR needs to be reverted because of the try push issues: #3052 (comment)

This change is Reviewable
kvark added 4 commits Sep 14, 2018
@kvark
Revert "Only build a transform palette when we need it."
bb040b9 
This reverts commit 31bc4b5.
@kvark
Revert "Avoid re-building the frame when we only need the hit tester."
62d8183 
This reverts commit a30cf48.
@kvark
Revert "Allow building the hit tester independently."
2cc5600 
This reverts commit 865642b.
@kvark
Revert "Avoid allocating small vectors when updating the clip scroll …
Loading status checks…
e215b34 
…tree."

This reverts commit 371c819.
@gw3583
Copy link
Collaborator

gw3583 commented Sep 14, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2018

📌 Commit e215b34 has been approved by gw3583
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2018

⌛ Testing commit e215b34 with merge f2db99e...
bors-servo added a commit that referenced this pull request Sep 14, 2018
@bors-servo
Auto merge of #3061 - kvark:hit-test-revert, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f2db99e 
Revert "Speed up updating the hit-test tree"

This PR needs to be reverted because of the try push issues: #3052 (comment)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3061)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing f2db99e to master...
@bors-servo bors-servo merged commit e215b34 into servo:master Sep 14, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@kvark kvark deleted the kvark:hit-test-revert branch Sep 14, 2018
@zptan zptan mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kvark @gw3583 @bors-servo
You can’t perform that action at this time.