Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove app_units::Au into api::units, re-export Au #3062
Conversation
|
It seems to fail because of a "license check issue" on Linux - I don't understand that, I didn't change anything about licenses. Maybe a style lint issue? |
|
It's not clear to me what that means either - you might be able to get more info by running that step locally? (the taskcluster / appveyor config files should have the command info). |
|
|
|
The reason I couldn't run in offline was because it runs |
|
@fschutt maybe this is what it's really complaining about:
|
|
Alright, seems to have fixed itself. Rebased on master to resolve the merge conflicts. |
|
@fschutt could you squash the commits please? it is nice when each commit can be later investigated independently, which doesn't appear to be the case (e.g. "fixed Au imports"). |
|
|
`ClipItem::new_box_shadow()`. If no blur is present, `DisplayListFlattener::add_box_shadow()` calls `ClipItem::new_rounded_rect()` in its fast path, which calls `ensure_no_corner_overlap()`. However, in the slow path, which is used when blur is present, `ClipItem::new_box_shadow()` is called instead. Prior to this patch, `ClipItem::new_box_shadow()` neglected to call `ensure_no_corner_overlap()`. This is why the bug manifested itself only when blur was present. Closes #2581.
Fixes #3045 Now we can update app_units in one place (the webrender_api crate) instead of having to track the version of app_units in every tool. Also any dependencies that build upon webrender now don't have to worry about tracking what version of app_units webrender is using. Also created a new `create_app_units_from_px` which does the required validation from pixel values to Au. Adressed style lint issues Rebased changes from servo:master + fixed Au imports
|
I think this can be closed, since |
fschutt commentedSep 14, 2018
•
edited by larsbergstrom
Fixes #3045
Now we can update app_units in one place (the webrender_api crate) instead of having to track the version of app_units in every tool. Also any dependencies that build upon webrender now don't have to worry about tracking what version of app_units webrender is using.
Also created a new
create_app_units_from_pxwhich does the required validation from pixel values to Au.This change is