Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace BorderWidths with SideOffsets2D #3065
Merged
Conversation
|
Looks great! @bors-servo r+
That would be nice. |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 17, 2018
Replace BorderWidths with SideOffsets2D closes #3053 While I am at it, should I also replace BorderWidthsAu and remove the border outset? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3065) <!-- Reviewable:end -->
|
@jrmuizel heads up there will be a few things to change in the API for next WR update although it should straightforward since BorderWidths and SideOffsets have the same members. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pyfisch commentedSep 17, 2018
•
edited by larsbergstrom
closes #3053
While I am at it, should I also replace BorderWidthsAu and remove the border outset?
This change is