Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmodified config lines to specify platforms #308
Conversation
metajack
commented
Jul 6, 2016
|
Patch looks fine, but I'm curious why you only changed some of these? For example, in |
|
I'm sorry, grep isn't turning up anything in those files for me--can you give me a line no? I only changed lines that were targeting platforms that were defined as "neither gonk nor android" and I don't see any of those left in the patches I submitted. I left the cfg lines that were targeting gonk and android alone because that's what Glenn had done originally/that made sense. |
metajack
commented
Jul 6, 2016
|
@bors-servo r+ Sorry, I misread those lines. |
|
|
modified config lines to specify platforms the previous PR had a merge conflict in device.rs but this should work r? @larsbergstrom
|
|
lanamorgan commentedJul 5, 2016
the previous PR had a merge conflict in device.rs but this should work
r? @larsbergstrom