Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call `ensure_no_corner_overlap()` to legalize border radii in `ClipItem::new_box_shadow()`. #3080

Merged

Commits on Sep 18, 2018

  1. Call `ensure_no_corner_overlap()` to legalize border radii in

    `ClipItem::new_box_shadow()`.
    
    If no blur is present, `DisplayListFlattener::add_box_shadow()` calls
    `ClipItem::new_rounded_rect()` in its fast path, which calls
    `ensure_no_corner_overlap()`. However, in the slow path, which is used when
    blur is present, `ClipItem::new_box_shadow()` is called instead. Prior to this
    patch, `ClipItem::new_box_shadow()` neglected to call
    `ensure_no_corner_overlap()`. This is why the bug manifested itself only when
    blur was present.
    
    Closes #2581.
    pcwalton committed Sep 18, 2018
You can’t perform that action at this time.