Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor things. #3081

Merged
merged 3 commits into from Sep 19, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

wrench: Make yaml reader and writer agree on how the id of a referenc…

…e frame is spelled.

This was needed to create some test-cases without a gazillion panics.
  • Loading branch information
emilio committed Sep 18, 2018
commit 051926243f6ce4afe5bdc6e8f7d78b40daa0e86f
@@ -35,7 +35,7 @@ root:
bounds: [110, 10, 100, 100]
clip-rect: [110, 10, 100, 100]
clip-and-scroll: root-reference-frame
reference-frame-id: 4
id: 4
type: stacking-context
transform: [1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1]
items:
@@ -17,7 +17,7 @@ root:
- type: stacking-context
bounds: [0, 0, 50, 50]
transform: translate(60, 100)
reference-frame-id: 100
id: 100
items:
- type: stacking-context
bounds: [0, 0, 50, 50]
@@ -31,7 +31,7 @@ root:
- type: stacking-context
bounds: [120, 0, 50, 200]
transform: translate(0, 0)
reference-frame-id: 101
id: 101
items:
- type: stacking-context
bounds: [0, 0, 50, 200]
@@ -44,7 +44,7 @@ root:
- type: stacking-context
bounds: [180, 0, 50, 200]
perspective: 1
reference-frame-id: 102
id: 102
items:
- type: stacking-context
bounds: [0, 0, 50, 200]
@@ -1545,7 +1545,7 @@ impl YamlFrameReader {

let reference_frame_id = dl.push_reference_frame(info, transform.into(), perspective);

let numeric_id = yaml["reference-frame-id"].as_i64();
let numeric_id = yaml["id"].as_i64();
if let Some(numeric_id) = numeric_id {
self.add_clip_id_mapping(numeric_id as u64, reference_frame_id);
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.