Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reftest for rounded clips under extreme perspective. #3083

Merged
merged 1 commit into from Sep 19, 2018

Conversation

@pcwalton
Copy link
Collaborator

pcwalton commented Sep 18, 2018

Closes #2421.

r? @gw3583


This change is Reviewable

@gw3583
Copy link
Collaborator

gw3583 commented Sep 18, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

📌 Commit d840b49 has been approved by gw3583

@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

Testing commit d840b49 with merge d46a634...

bors-servo added a commit that referenced this pull request Sep 18, 2018
…w3583

Add a reftest for rounded clips under extreme perspective.

Closes #2421.

r? @gw3583

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3083)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2018

💔 Test failed - status-taskcluster

@pcwalton pcwalton force-pushed the pcwalton:reftest-perspective-border-radius branch from d840b49 to 1e664ca Sep 18, 2018
@pcwalton
Copy link
Collaborator Author

pcwalton commented Sep 18, 2018

Made that reftest fuzzy. I verified that it looks right under Linux.

@gw3583
Copy link
Collaborator

gw3583 commented Sep 19, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

📌 Commit 1e664ca has been approved by gw3583

bors-servo added a commit that referenced this pull request Sep 19, 2018
…w3583

Add a reftest for rounded clips under extreme perspective.

Closes #2421.

r? @gw3583

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3083)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

Testing commit 1e664ca with merge bf8f121...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

💔 Test failed - status-taskcluster

@pcwalton pcwalton force-pushed the pcwalton:reftest-perspective-border-radius branch from 1e664ca to 2254664 Sep 19, 2018
@kvark
Copy link
Member

kvark commented Sep 19, 2018

platform(linux,mac) fuzzy(9,347) == perspective-border-radius.yaml perspective-border-radius.png

max difference: 9, number of differing pixels: 348

🤣
Let's fuzz it some more?

@pcwalton pcwalton force-pushed the pcwalton:reftest-perspective-border-radius branch from 2254664 to 5f44044 Sep 19, 2018
@pcwalton
Copy link
Collaborator Author

pcwalton commented Sep 19, 2018

Off-by-one error!

@kvark
Copy link
Member

kvark commented Sep 19, 2018

@bors-servo r=gw3583

@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

📌 Commit 5f44044 has been approved by gw3583

@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

Testing commit 5f44044 with merge 92bedd4...

bors-servo added a commit that referenced this pull request Sep 19, 2018
…w3583

Add a reftest for rounded clips under extreme perspective.

Closes #2421.

r? @gw3583

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3083)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing 92bedd4 to master...

@bors-servo bors-servo merged commit 5f44044 into servo:master Sep 19, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@pcwalton pcwalton deleted the pcwalton:reftest-perspective-border-radius branch Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.