Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant frame builds (take two). #3092

Merged
merged 4 commits into from Sep 26, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Allow building the hit tester independently.

  • Loading branch information
nical committed Sep 20, 2018
commit 4ea28c9937657e6794d76439b2930818aa997649
@@ -293,6 +293,24 @@ impl Document {
}
}

fn rebuild_hit_tester(&mut self) {
if let Some(ref mut frame_builder) = self.frame_builder {
let accumulated_scale_factor = self.view.accumulated_scale_factor();
let pan = self.view.pan.to_f32() / accumulated_scale_factor;

// TODO: do we need to do something with the transform palette?
let _palette = self.clip_scroll_tree.update_tree(
pan,
&self.dynamic_properties,
);

self.hit_tester = Some(frame_builder.create_hit_tester(
&self.clip_scroll_tree,
&self.clip_data_store,
));
}
}

pub fn updated_pipeline_info(&mut self) -> PipelineInfo {
let removed_pipelines = replace(&mut self.removed_pipelines, Vec::new());
PipelineInfo {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.