Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp radius in blur filters to a sensible value. #3120

Merged
merged 1 commit into from Sep 25, 2018

Conversation

@gw3583
Copy link
Collaborator

gw3583 commented Sep 25, 2018

Fixes #3118.


This change is Reviewable

@gw3583 gw3583 force-pushed the gw3583:big-blur branch from da41634 to 2665e7e Sep 25, 2018
@gw3583 gw3583 force-pushed the gw3583:big-blur branch from 2665e7e to ebe50f2 Sep 25, 2018
@kvark
kvark approved these changes Sep 25, 2018
Copy link
Member

kvark left a comment

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gw3583)


webrender_api/src/display_item.rs, line 620 at r1 (raw file):

    /// Ensure that the parameters for a filter operation
    /// are sensible.
    pub fn sanitize(self) -> FilterOp {

nit: it would look much simpler if it was &mut self

@gw3583
Copy link
Collaborator Author

gw3583 commented Sep 25, 2018

Try looks good.

@bors-servo r=kvark

@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2018

📌 Commit ebe50f2 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2018

Testing commit ebe50f2 with merge 7d1f150...

bors-servo added a commit that referenced this pull request Sep 25, 2018
Clamp radius in blur filters to a sensible value.

Fixes #3118.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3120)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 7d1f150 to master...

@bors-servo bors-servo merged commit ebe50f2 into servo:master Sep 25, 2018
3 of 4 checks passed
3 of 4 checks passed
code-review/reviewable 1 discussion left (gw3583)
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.