Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upA bit cleanup of NEXT_NAMESPACE_ID #3127
Merged
Conversation
|
I think it used to be this way due to a restriction in rustc. Is the minimum rustc version required by Gecko sufficient to support this change now? |
|
Ah, I recalled #1882 (comment). feature(const_atomic_usize_new) was already removed by rust-lang/rust#46287. And AtomicUsize::new(1) is stabilized API and could be used on gecko. |
|
@bors-servo r+ Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 26, 2018
A bit cleanup of NEXT_NAMESPACE_ID Initialization becomes simpler with AtomicUsize::new(1). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3127) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sotaroikeda commentedSep 26, 2018
•
edited by larsbergstrom
Initialization becomes simpler with AtomicUsize::new(1).
This change is