Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove the scroll bar APIs. #3134
Merged
Conversation
It's much better if applications draw scrollbars by adding normal primitives to the display list. This means: * Better control of how they look visually. * Can make them clickable / draggable. * Less code complexity in WR. * Better control of scrollbar behavior (where enabled etc).
|
This reduces code complexity for some other ongoing work (since scroll bar codes relies on global primitive indices). However, let's not merge this until we have a resolution to my questions in servo/servo#21817. |
gw3583
changed the title
|
r? @kvark or anyone |
|
Seems great, r=me when you're ready to land |
|
@bors-servo r=Gankro |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 28, 2018
Remove the scroll bar APIs. It's much better if applications draw scrollbars by adding normal primitives to the display list. This means: * Better control of how they look visually. * Can make them clickable / draggable. * Less code complexity in WR. * Better control of scrollbar behavior (where enabled etc). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3134) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gw3583 commentedSep 27, 2018
•
edited by larsbergstrom
It's much better if applications draw scrollbars by adding normal
primitives to the display list. This means:
This change is