Add comments, rename things, remove unused code

[bholley]

CC @nical @kvark @gw3583

r? whoever wants to take it.

---

This change is 

[kvark]

Looks pretty good! I have a few minor concerns, please feel free to r=me anyhow.

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @bholley)

---

webrender/src/internal_types.rs, line 48 at r1 (raw file):

}

/// Represents a texture that serves as input to a shader.

I think the meaning of this enum is more about where the texture comes from, rather than where it goes to (i.e. the shader).

---

webrender/src/render_task.rs, line 190 at r1 (raw file):

    ///
    /// The second member specifies the width and height of the task
    /// output, and the first member is initially left blank. During the build

"blank" -> None ?

---

webrender/src/tiling.rs, line 342 at r1 (raw file):

pub struct GlyphJob;

/// Represents a regular color output surface, RGBA32.

In WR, the convention is to specify bits per channel here, i.e. RGBA8

---

webrender/src/tiling.rs, line 342 at r1 (raw file):

pub struct GlyphJob;

/// Represents a regular color output surface, RGBA32.

I'd say, rather, that this structure contains all the work (in the form of instance arrays) needed to fill a color surface

[bholley]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @kvark)

---

webrender/src/internal_types.rs, line 48 at r1 (raw file):

Previously, kvark (Dzmitry Malyshau) wrote…

I think the meaning of this enum is more about where the texture comes from, rather than where it goes to (i.e. the shader).

Done.

---

webrender/src/render_task.rs, line 190 at r1 (raw file):

Previously, kvark (Dzmitry Malyshau) wrote…

"blank" -> None ?

Done.

---

webrender/src/tiling.rs, line 342 at r1 (raw file):

Previously, kvark (Dzmitry Malyshau) wrote…

In WR, the convention is to specify bits per channel here, i.e. RGBA8

I was cribbing from the existing comment in RenderTargetKind, I'll fix that one up as well.

---

webrender/src/tiling.rs, line 342 at r1 (raw file):

Previously, kvark (Dzmitry Malyshau) wrote…

I'd say, rather, that this structure contains all the work (in the form of instance arrays) needed to fill a color surface

Got it. I assume I should fix up AlphaRenderTarget as well.

[bholley]

Added more commits. r? @kvark

[kvark]

Reviewed 28 of 28 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[kvark]

@bors-servo r+

[bors-servo]

📌 Commit f29f465 has been approved by kvark

[bors-servo]

⌛ Testing commit f29f465 with merge 005b36d...

[bors-servo]

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 005b36d to master...