Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPass device pixel scale via picture render task data. #3150
Conversation
|
Try run looks good. |
my main concern would be testing this. Does Gecko's CI have any bots with non-unit device/pixel ration?
if not, would be good to get that build on a few machines and run
webrender/res/snap.glsl, line 18 at r1 (raw file):
given the number of times we need to divide by it, we should probably provide the reciprocal (as an extra) from CPU side webrender/src/device/gl.rs, line 527 at r1 (raw file):
|
|
|
webrender/res/snap.glsl, line 18 at r1 (raw file): Previously, kvark (Dzmitry Malyshau) wrote…
Filed #3157 webrender/src/device/gl.rs, line 527 at r1 (raw file): Previously, kvark (Dzmitry Malyshau) wrote…
Done. |
|
Filed #3157 and rebased. I agree with the testing comment. I did a fair amount of manual testing in wrench with difference ratios, and it seems OK, but I'm not sure how good our CI coverage is. Once I start to leverage this for rasterizing pictures at different scales, we can definitely get some good CI coverage via that. |
|
@bors-servo r+ |
|
|
Pass device pixel scale via picture render task data. As a follow up, we will be able to include a per-picture local scaling factor. This can be used for drawing pictures in local space at a specific scale factor. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3150) <!-- Reviewable:end -->
|
|
gw3583 commentedOct 2, 2018
•
edited by larsbergstrom
As a follow up, we will be able to include a per-picture
local scaling factor. This can be used for drawing pictures
in local space at a specific scale factor.
This change is