Apply a basis change on the perspective transform. #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When applying async scrolling transforms, the perspective matrix also needs to be adjusted with a basis change. This is a version of servo#3154 that doesn't break async scrolling on 2D-transformed elements. Although this passes the required test cases and displays correct behaviour, the intuition behind why this works is not really clear to me; see https://bugzilla.mozilla.org/show_bug.cgi?id=1415272#c23 onwards for some discussion.
|
@bors-servo r+ let's see if this is The One! |
|
📌 Commit 735a563 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 5, 2018
Apply a basis change on the perspective transform. When applying async scrolling transforms, the perspective matrix also needs to be adjusted with a basis change. This is a version of #3154 that doesn't break async scrolling on 2D-transformed elements. Although this passes the required test cases and displays correct behaviour, the intuition behind why this works is not really clear to me; see https://bugzilla.mozilla.org/show_bug.cgi?id=1415272#c23 onwards for some discussion. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3173) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying async scrolling transforms, the perspective matrix also
needs to be adjusted with a basis change. This is a version of #3154
that doesn't break async scrolling on 2D-transformed elements. Although
this passes the required test cases and displays correct behaviour,
the intuition behind why this works is not really clear to me; see
https://bugzilla.mozilla.org/show_bug.cgi?id=1415272#c23 onwards for
some discussion.
This change is