Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStop reinitializing textures #3183
Merged
Conversation
This is a prerequisite to switching to immutable storage. Differential Revision: https://phabricator.services.mozilla.com/D8161
Differential Revision: https://phabricator.services.mozilla.com/D8162
Differential Revision: https://phabricator.services.mozilla.com/D8163
We also drop the vec scheme and just use a hash-map. None of the operations here are hot enough that the difference between a HashMap and a Vec should matter, and using a HashMap simplifies things. Glenn says that hashmap lookups were once hot in profiles, but that was before FastHashMap and not specifically these lookups. Differential Revision: https://phabricator.services.mozilla.com/D8164
Differential Revision: https://phabricator.services.mozilla.com/D8165
Things get simpler when reinitialization goes away. Differential Revision: https://phabricator.services.mozilla.com/D8166
|
My concerns have been addressed, and the only remaining one - about hashmap - is being discussed, but it's not a ton of work to bring back the vector indexation in case we need it. |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 11, 2018
Stop reinitializing textures This was reviewed in [1]. @kvark, can you confirm that you don't have any additional feedback? Feel free to trigger landing if you don't. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1497665 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3183) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bholley commentedOct 10, 2018
•
edited by larsbergstrom
This was reviewed in [1]. @kvark, can you confirm that you don't have any additional feedback? Feel free to trigger landing if you don't.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1497665
This change is