Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reinitializing textures #3183

Merged
merged 7 commits into from Oct 11, 2018
Merged

Stop reinitializing textures #3183

merged 7 commits into from Oct 11, 2018
+421 −532

Commits on Oct 10, 2018

  1. Stop reinitializing render targets with different dimensions. 

    This is a prerequisite to switching to immutable storage.

Differential Revision: https://phabricator.services.mozilla.com/D8161
    @bholley
    bholley committed Oct 10, 2018
    cfe69c1

  2. Stop reinitializing the GPU cache texture with different dimensions. 

    Differential Revision: https://phabricator.services.mozilla.com/D8162
    @bholley
    bholley committed Oct 10, 2018
    e37d135

  3. Stop reinitializing VertexDataTextures with different dimensions. 

    Differential Revision: https://phabricator.services.mozilla.com/D8163
    @bholley
    bholley committed Oct 10, 2018
    a31337a

  4. Stop reinitializing freed texture cache textures. 

    We also drop the vec scheme and just use a hash-map. None of the operations
here are hot enough that the difference between a HashMap and a Vec
should matter, and using a HashMap simplifies things. Glenn says that
hashmap lookups were once hot in profiles, but that was before
FastHashMap and not specifically these lookups.

Differential Revision: https://phabricator.services.mozilla.com/D8164
    @bholley
    bholley committed Oct 10, 2018
    ad53a1b

  5. Combine texture creation and initialization into the same API. 

    Differential Revision: https://phabricator.services.mozilla.com/D8165
    @bholley
    bholley committed Oct 10, 2018
    7fa14ae

  6. Simplify device texture management. 

    Things get simpler when reinitialization goes away.

Differential Revision: https://phabricator.services.mozilla.com/D8166
    @bholley
    bholley committed Oct 10, 2018
    4e58b70

  7. Eliminate free_texture_storage.

    @bholley
    bholley committed Oct 10, 2018
    Loading status checks…
    788d251
You can’t perform that action at this time.