Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to immutable texture storage and invalidate unused framebuffers #3195

Merged
merged 6 commits into from Oct 13, 2018
Merged

Switch to immutable texture storage and invalidate unused framebuffers #3195

merged 6 commits into from Oct 13, 2018
+197 −81

Commits on Oct 12, 2018

  1. Bump gleam to 0.6.3.

    @bholley
    bholley committed Oct 12, 2018
    5a914be

  2. Switch FormatDesc::internal to GLenum. 

    That's the proper type. The fact that the glTexImage* calls take a glint
is a specific wart of that API that's not relevant to us here.

Differential Revision: https://phabricator.services.mozilla.com/D8564
    @bholley
    bholley committed Oct 12, 2018
    6e80ae2

Commits on Oct 13, 2018

  1. Make creation-time immediate texture upload explicit. 

    The current setup doesn't work with glTexStorage. Given that it's only
used for a few callers, it's cleanest to move it to an explicit call at
those sites.

Differential Revision: https://phabricator.services.mozilla.com/D8565
    @bholley
    bholley committed Oct 13, 2018
    b79e230

  2. Always use a sized internal format. 

    This is required by glTexStorage*. We also take the opportunity to
simplify and clarify the situation with BGRA.

Differential Revision: https://phabricator.services.mozilla.com/D8566
    @bholley
    bholley committed Oct 13, 2018
    ffa6bb3

  3. Use glTexStorage* where available. 

    Differential Revision: https://phabricator.services.mozilla.com/D8567
    @bholley
    bholley committed Oct 13, 2018
    ccdede2

  4. Invalidate render targets when returning them to the pool. 

    This allows the driver to avoid preserving the old contents we don't
care about.

Differential Revision: https://phabricator.services.mozilla.com/D8568
    @bholley
    bholley committed Oct 13, 2018
    Loading status checks…
    36cb19d
You can’t perform that action at this time.