Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd border segments to the opaque render pass where possible. #3208
Conversation
Use the new per-segment instance data to allow specifying a per-segment opacity value. This is used for border segments to specify which border segments are opaque. Any time we move segments or primitives to the opaque pass is typically a significant GPU time win due to the reduced overdraw. It's also a CPU optimization during batching.
|
Try looks good. @bors-servo r=nical |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 17, 2018
Add border segments to the opaque render pass where possible. Use the new per-segment instance data to allow specifying a per-segment opacity value. This is used for border segments to specify which border segments are opaque. Any time we move segments or primitives to the opaque pass is typically a significant GPU time win due to the reduced overdraw. It's also a CPU optimization during batching. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3208) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gw3583 commentedOct 17, 2018
•
edited by larsbergstrom
Use the new per-segment instance data to allow specifying a
per-segment opacity value. This is used for border segments
to specify which border segments are opaque.
Any time we move segments or primitives to the opaque pass
is typically a significant GPU time win due to the reduced
overdraw. It's also a CPU optimization during batching.
This change is