New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid capturing platform-specific font data #3215

Merged
merged 2 commits into from Oct 19, 2018

Conversation

Projects
None yet
3 participants
@kvark
Member

kvark commented Oct 18, 2018

This PR avoids the capturing to carry or load the platform-specific font instance data. It's less ideal for the case where the replay is done on the same platform, but makes captures more robust and portable overall. Ideally, we'd want to still save it but ignore on other platforms, but this would be less trivial (TODO).
r? anyone


This change is Reviewable

@gw3583

gw3583 approved these changes Oct 18, 2018

One spelling nit - tried to use the new suggestion feature to add a fix for it.

Show resolved Hide resolved webrender/src/capture.rs Outdated
fix spellig of capture loading error
Co-Authored-By: kvark <kvarkus@gmail.com>
@kvark

This comment has been minimized.

Member

kvark commented Oct 19, 2018

thanks!
@bors-servo r=gw3583

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 19, 2018

📌 Commit fef45d5 has been approved by gw3583

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 19, 2018

⌛️ Testing commit fef45d5 with merge f4941fb...

bors-servo added a commit that referenced this pull request Oct 19, 2018

Auto merge of #3215 - kvark:wr-font-capture, r=gw3583
Avoid capturing platform-specific font data

This PR avoids the capturing to carry or load the platform-specific font instance data. It's less ideal for the case where the replay is done on the same platform, but makes captures more robust and portable overall. Ideally, we'd want to still save it but ignore on other platforms, but this would be less trivial (TODO).
r? anyone

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3215)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 19, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: gw3583
Pushing f4941fb to master...

@bors-servo bors-servo merged commit fef45d5 into servo:master Oct 19, 2018

2 of 3 checks passed

Taskcluster (pull_request) TaskGroup: Pending (for pull_request.synchronize)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@kvark kvark deleted the kvark:wr-font-capture branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment