Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip clip masks with tiled blobs, instead of crashing. #3219

Merged
merged 2 commits into from Oct 19, 2018
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev

Add a comment for the boolean member in ClipItem::ImageMask.

  • Loading branch information
emilio committed Oct 19, 2018
commit 207cfec1a94fd0440f0e3b9cd29b26c58333d3b5
@@ -773,6 +773,8 @@ impl ClipItemKey {
pub enum ClipItem {
Rectangle(LayoutRect, ClipMode),
RoundedRectangle(LayoutRect, BorderRadius, ClipMode),
/// The boolean below is a crash workaround for #2852, will be true unless
/// the mask is a tiled blob.
Image(ImageMask, bool),

This comment has been minimized.

@nical

nical Oct 19, 2018

Collaborator

Please make the boolean a named field or add a comment, It takes a bit of looking around to find what it is for (batch.rs is the only place where the meaning is explicit, and it's not where I'd look first),

BoxShadow(BoxShadowClipSource),
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.