New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local data during interning. #3224

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Collaborator

gw3583 commented Oct 23, 2018

This doesn't currently store any data, but it adds the support
in the interner for future use.


This change is Reviewable

Support local data during interning.
This doesn't currently store any data, but it adds the support
in the interner for future use.
@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Oct 23, 2018

This doesn't achieve anything useful with the new functionality, just yet. But I'm trying to land isolated patches where possible to make reviews easier. If you'd prefer, we can wait until the follow up that makes use of this functionality is ready, before reviewing / merging this.

r? @kvark or @nical

@nical

This comment has been minimized.

Collaborator

nical commented Oct 23, 2018

Looks reasonable. @bors-servo r+

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 23, 2018

📌 Commit 517012e has been approved by nical

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 23, 2018

⌛️ Testing commit 517012e with merge a7052ab...

bors-servo added a commit that referenced this pull request Oct 23, 2018

Auto merge of #3224 - gw3583:prim-instances-2, r=nical
Support local data during interning.

This doesn't currently store any data, but it adds the support
in the interner for future use.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3224)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 23, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing a7052ab to master...

@bors-servo bors-servo merged commit 517012e into servo:master Oct 23, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment