New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Primitive methods to PrimitiveInstance. #3228

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Collaborator

gw3583 commented Oct 24, 2018

This is a small change towards reducing implementation details
on the Primitive struct. Eventually, Primitive will be removed
and we'll just have PrimitiveInstance and PrimitiveTemplate.

The PrimitiveTemplate struct will be the interned and shared
data for primitives that are the same across display lists.

The PrimitiveInstance struct currently contains information
calculated in prepare_prims and then used by batching. Once
we move the prepare prims code from the first (picture tree
pass) into the batching pass, most of the storage in the
PrimitiveInstance can be removed and used immediately.


This change is Reviewable

Move Primitive methods to PrimitiveInstance.
This is a small change towards reducing implementation details
on the Primitive struct. Eventually, Primitive will be removed
and we'll just have PrimitiveInstance and PrimitiveTemplate.

The PrimitiveTemplate struct will be the interned and shared
data for primitives that are the same across display lists.

The PrimitiveInstance struct currently contains information
calculated in prepare_prims and then used by batching. Once
we move the prepare prims code from the first (picture tree
pass) into the batching pass, most of the storage in the
PrimitiveInstance can be removed and used immediately.
@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Oct 24, 2018

r? @nical or @kvark

This probably looks like bike-shedding, but there's method to the madness. I'm hoping to be able to land some of the more substantial work I have for picture caching locally in the next few days.

@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Oct 24, 2018

This shouldn't have any functional effect at all, but I'll kick off a try run later tonight to be on the safe side.

@gw3583

This comment has been minimized.

@nical

nical approved these changes Oct 24, 2018

Okay, sure.

@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Oct 24, 2018

Try looks good.

@bors-servo r=nical

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 24, 2018

📌 Commit 1cfbefc has been approved by nical

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 24, 2018

⌛️ Testing commit 1cfbefc with merge 70fd627...

bors-servo added a commit that referenced this pull request Oct 24, 2018

Auto merge of #3228 - gw3583:prim-instance, r=nical
Move Primitive methods to PrimitiveInstance.

This is a small change towards reducing implementation details
on the Primitive struct. Eventually, Primitive will be removed
and we'll just have PrimitiveInstance and PrimitiveTemplate.

The PrimitiveTemplate struct will be the interned and shared
data for primitives that are the same across display lists.

The PrimitiveInstance struct currently contains information
calculated in prepare_prims and then used by batching. Once
we move the prepare prims code from the first (picture tree
pass) into the batching pass, most of the storage in the
PrimitiveInstance can be removed and used immediately.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3228)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 24, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 70fd627 to master...

@bors-servo bors-servo merged commit 1cfbefc into servo:master Oct 24, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@gw3583 gw3583 deleted the gw3583:prim-instance branch Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment