Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce picture traversal pass. #3229
Merged
+251
−67
Conversation
|
Looks like this has a couple of failures on try that I need to investigate. |
|
Tidied up the patch and (hopefully) fixed the try failures. New pending try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=447816626448ba1e5ad5e5bf9c0d954db6d30a03 |
This introduces a new pass during frame building. It's a very quick pass, since we only traverse the picture tree. This pass must not access individual primitives. In the future, the prepare_prims pass will be split into two parts. Some of the work done in that pass will be moved to this picture traversal pass (e.g. plane splitting), while the rest (e.g GPU cache updates) will be moved to the batching pass. The outcome of the first pass will determine whether a picture has a valid cached surface, and thus decide whether the second primitive preparation and batching pass is required to build a new surface cache.
|
Try run isn't quite finished but looks good so far. |
|
complete! all files reviewed, all discussions resolved
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 25, 2018
Introduce picture traversal pass. This introduces a new pass during frame building. It's a very quick pass, since we only traverse the picture tree. This pass must not access individual primitives. In the future, the prepare_prims pass will be split into two parts. Some of the work done in that pass will be moved to this picture traversal pass (e.g. plane splitting), while the rest (e.g GPU cache updates) will be moved to the batching pass. The outcome of the first pass will determine whether a picture has a valid cached surface, and thus decide whether the second primitive preparation and batching pass is required to build a new surface cache. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3229) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gw3583 commentedOct 25, 2018
•
edited by larsbergstrom
This introduces a new pass during frame building. It's a very
quick pass, since we only traverse the picture tree. This pass
must not access individual primitives.
In the future, the prepare_prims pass will be split into two
parts. Some of the work done in that pass will be moved to this
picture traversal pass (e.g. plane splitting), while the rest
(e.g GPU cache updates) will be moved to the batching pass.
The outcome of the first pass will determine whether a picture
has a valid cached surface, and thus decide whether the second
primitive preparation and batching pass is required to build
a new surface cache.
This change is