Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPrepare opacity consistently #3233
Merged
Conversation
|
Looks good to me once try completes. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 26, 2018
Prepare opacity consistently This is a follow-up to #3232 It makes opacity computation more functional, having us to consider it equally important for all primitive types. It's not supposed to change any logic. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e4ca6f1b473522e93d5fd11e64c563c2bdf50dd <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3233) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 31, 2018
Fix opacity of Clear brushes Follow-up to #3233 Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1502585 Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2319bbf4ce04d1af7a785567c09d43884b8c3ca3 cc @staktrace r? anyone (once the try is green) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3252) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Oct 31, 2018
Fix opacity of Clear brushes Follow-up to #3233 Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1502585 Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2319bbf4ce04d1af7a785567c09d43884b8c3ca3 cc @staktrace r? anyone (once the try is green) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3252) <!-- Reviewable:end -->
|
This seemed to have slightly improved performance [1]. Was that at all expected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedOct 25, 2018
•
edited by larsbergstrom
This is a follow-up to #3232
It makes opacity computation more functional, having us to consider it equally important for all primitive types. It's not supposed to change any logic.
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e4ca6f1b473522e93d5fd11e64c563c2bdf50dd
This change is