Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProperly evict cached blob tiles when they are out of the visible area. #3250
Conversation
|
cc @mstange |
|
Try looks good. r? anyone who knows about resource_cache |
|
Fixes #3125. |
|
complete! all files reviewed, all discussions resolved
|
@bors-servo r=aosmond |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 31, 2018
Properly evict cached blob tiles when they are out of the visible area. This fixes [bug 1494173](https://bugzilla.mozilla.org/show_bug.cgi?id=1503220). Before this PR we would discard the rasterized blob image but not the cache entries (which didn't mesh well with the manual eviction policy, so tiles would stick around until the image key is deleted). This aggressively removes the cached tile entry as well as the texture cache entry as soon as the tile is out of the visible area. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3250) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedOct 30, 2018
•
edited
This fixes bug 1494173. Before this PR we would discard the rasterized blob image but not the cache entries (which didn't mesh well with the manual eviction policy, so tiles would stick around until the image key is deleted).
This aggressively removes the cached tile entry as well as the texture cache entry as soon as the tile is out of the visible area.
This change is