New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly evict cached blob tiles when they are out of the visible area. #3250

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@nical
Collaborator

nical commented Oct 30, 2018

This fixes bug 1494173. Before this PR we would discard the rasterized blob image but not the cache entries (which didn't mesh well with the manual eviction policy, so tiles would stick around until the image key is deleted).
This aggressively removes the cached tile entry as well as the texture cache entry as soon as the tile is out of the visible area.


This change is Reviewable

@nical

This comment has been minimized.

Collaborator

nical commented Oct 30, 2018

@nical

This comment has been minimized.

@nical

This comment has been minimized.

Collaborator

nical commented Oct 31, 2018

Try looks good. r? anyone who knows about resource_cache

@nical

This comment has been minimized.

Collaborator

nical commented Oct 31, 2018

Fixes #3125.

@aosmond

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@nical

This comment has been minimized.

Collaborator

nical commented Oct 31, 2018

@bors-servo r=aosmond

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 31, 2018

📌 Commit ab8ed4e has been approved by aosmond

bors-servo added a commit that referenced this pull request Oct 31, 2018

Auto merge of #3250 - nical:blob-tile-discard, r=aosmond
Properly evict cached blob tiles when they are out of the visible area.

This fixes [bug 1494173](https://bugzilla.mozilla.org/show_bug.cgi?id=1503220). Before this PR we would discard the rasterized blob image but not the cache entries (which didn't mesh well with the manual eviction policy, so tiles would stick around until the image key is deleted).
This aggressively removes the cached tile entry as well as the texture cache entry as soon as the tile is out of the visible area.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3250)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 31, 2018

⌛️ Testing commit ab8ed4e with merge 1928351...

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Oct 31, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: aosmond
Pushing 1928351 to master...

@bors-servo bors-servo merged commit ab8ed4e into servo:master Oct 31, 2018

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
code-review/reviewable 1 file reviewed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@nical nical deleted the nical:blob-tile-discard branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment