Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up standalone texture cache eviction #3269

Merged
merged 8 commits into from Nov 5, 2018

Commits on Nov 5, 2018

  1. Track the total number of GPU bytes allocated by WebRender.

    This is useful for sanity-checking memory reports, and we'll also use it
    for our texture eviction heuristic.
    
    Differential Revision: https://phabricator.services.mozilla.com/D10672
    bholley committed Nov 5, 2018
  2. Switch GpuCache frame_id tracking from device::FrameId to render_back…

    …end::FrameId.
    
    It should really be using the latter, so that it can avoid hand-rolling
    the frame increments and just use the one already available on
    frame_builder.
    
    In the next patch, we rename the types to make the difference clearer.
    
    Differential Revision: https://phabricator.services.mozilla.com/D10673
    bholley committed Nov 5, 2018
  3. Rename device::FrameId to device::GpuFrameId.

    This type identified frames as sequenced by the device layer, whereas
    render_backend::FrameId identifies frames as sequenced by the render
    backend. I'm not sure whether there are known cases where these will
    diverge, but it seems plausible that they might, and so we should more
    clearly distinguish the types.
    
    Differential Revision: https://phabricator.services.mozilla.com/D10674
    bholley committed Nov 5, 2018
  4. Support always-invalid WeakFreeListHandle and eliminate Option from T…

    …extureCacheHandle.
    
    This simplifies the texture cache code.
    
    Differential Revision: https://phabricator.services.mozilla.com/D10677
    bholley committed Nov 5, 2018
  5. Properly handle entries moving between shared and standalone.

    We also switch the boolean from 'in_shared_cache' to 'standalone', since the
    latter is a bit shorter.
    
    Differential Revision: https://phabricator.services.mozilla.com/D10678
    bholley committed Nov 5, 2018
  6. Fix standalone texture eviction.

    bholley committed Nov 5, 2018
You can’t perform that action at this time.