New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor render task chaining. #3276

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Collaborator

gw3583 commented Nov 6, 2018

Instead of passing render task dependencies via the PictureState
stack, directly append to the task list for the surface that
a picture is assigned to render on.

This is a small step to untangling the prepare_prims pass from
the picture traversal.


This change is Reviewable

Refactor render task chaining.
Instead of passing render task dependencies via the PictureState
stack, directly append to the task list for the surface that
a picture is assigned to render on.

This is a small step to untangling the prepare_prims pass from
the picture traversal.
@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Nov 6, 2018

@nical

This comment has been minimized.

Collaborator

nical commented Nov 6, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

📌 Commit 5ca7cf0 has been approved by nical

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

⌛️ Testing commit 5ca7cf0 with merge b9b8789...

bors-servo added a commit that referenced this pull request Nov 6, 2018

Auto merge of #3276 - gw3583:task-surface-2, r=nical
Refactor render task chaining.

Instead of passing render task dependencies via the PictureState
stack, directly append to the task list for the surface that
a picture is assigned to render on.

This is a small step to untangling the prepare_prims pass from
the picture traversal.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3276)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

💔 Test failed - status-taskcluster

@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Nov 6, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

⌛️ Testing commit 5ca7cf0 with merge 790b76f...

bors-servo added a commit that referenced this pull request Nov 6, 2018

Auto merge of #3276 - gw3583:task-surface-2, r=nical
Refactor render task chaining.

Instead of passing render task dependencies via the PictureState
stack, directly append to the task list for the surface that
a picture is assigned to render on.

This is a small step to untangling the prepare_prims pass from
the picture traversal.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3276)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 6, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 790b76f to master...

@bors-servo bors-servo merged commit 5ca7cf0 into servo:master Nov 6, 2018

2 of 3 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment