Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on sccache logging #3278

Merged
merged 1 commit into from Nov 8, 2018
Merged

Turn on sccache logging #3278

merged 1 commit into from Nov 8, 2018

Conversation

@staktrace
Copy link
Contributor

staktrace commented Nov 6, 2018

This should help track down #3248, per discussion with @luser on IRC.

r? anyone


This change is Reviewable

@@ -149,13 +149,21 @@ tasks:
git checkout {{event.head.sha}}
source $HOME/servotidy-venv/bin/activate
servo-tidy
sccache --stop-server || true

This comment has been minimized.

@luser

luser Nov 6, 2018

Contributor

You might want to stick a --stop-server invocation after your test steps as well, since sccache outputs stats after shutting down and those are useful to have in build logs.

@luser
Copy link
Contributor

luser commented Nov 6, 2018

This looks good to me.

@@ -149,13 +149,21 @@ tasks:
git checkout {{event.head.sha}}
source $HOME/servotidy-venv/bin/activate
servo-tidy
sccache --stop-server || true
export RUST_LOG=sccache=debug

This comment has been minimized.

@luser

luser Nov 6, 2018

Contributor

Actually, after looking at a build log on this PR, you probably don't want to export this, just put it in the --start-server line. Otherwise you get log spew every time cargo invokes sccache.

@luser
Copy link
Contributor

luser commented Nov 6, 2018

Here's sccache.log from the OS X debug tests task.

@staktrace staktrace force-pushed the staktrace:sccache branch from e4cd8a5 to fe05f66 Nov 6, 2018
@staktrace
Copy link
Contributor Author

staktrace commented Nov 6, 2018

Updated patch to address both comments

@staktrace
Copy link
Contributor Author

staktrace commented Nov 8, 2018

@bors-servo r=luser

(Having only one mac CI machine is really slowing things down, and apparently even that one is showing some errors, so getting this in sooner will help us debug what's going on)

@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

@staktrace: 🔑 Insufficient privileges: Not in reviewers

@jrmuizel
Copy link
Contributor

jrmuizel commented Nov 8, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

📌 Commit fe05f66 has been approved by jrmuizel

@jdm
Copy link
Member

jdm commented Nov 8, 2018

@jdm
Copy link
Member

jdm commented Nov 8, 2018

@bors-servo r=jrmuizel

@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

📌 Commit fe05f66 has been approved by jrmuizel

@jdm
Copy link
Member

jdm commented Nov 8, 2018

bors-servo added a commit that referenced this pull request Nov 8, 2018
Turn on sccache logging

This should help track down #3248, per discussion with @luser on IRC.

r? anyone

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3278)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

Testing commit fe05f66 with merge b882918...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: jrmuizel
Pushing b882918 to master...

@bors-servo bors-servo merged commit fe05f66 into servo:master Nov 8, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@staktrace staktrace deleted the staktrace:sccache branch Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.