New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move opacity from instance to template. #3283

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Collaborator

gw3583 commented Nov 7, 2018

The overall primitive opacity is a per-template property, not
per-instance. It's a small optimization to reduce the size of
each primitive instance.


This change is Reviewable

Move opacity from instance to template.
The overall primitive opacity is a per-template property, not
per-instance. It's a small optimization to reduce the size of
each primitive instance.
@gw3583

This comment has been minimized.

@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Nov 7, 2018

Try run looks good.

@nical

This comment has been minimized.

Collaborator

nical commented Nov 7, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 7, 2018

📌 Commit 3302b5e has been approved by nical

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 7, 2018

⌛️ Testing commit 3302b5e with merge b44b571...

bors-servo added a commit that referenced this pull request Nov 7, 2018

Auto merge of #3283 - gw3583:temp2, r=nical
Move opacity from instance to template.

The overall primitive opacity is a per-template property, not
per-instance. It's a small optimization to reduce the size of
each primitive instance.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3283)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 7, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing b44b571 to master...

@bors-servo bors-servo merged commit 3302b5e into servo:master Nov 7, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@gw3583 gw3583 deleted the gw3583:temp2 branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment