Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCombine webrender_traits and webrender #330
Merged
+2,377
−3
Conversation
Switch to using ipc-channel.
Support native fonts again post-e10s.
Add WebGL support
Move all the common WebGL code to webrender_traits
Make `MixBlendMode` hashable.
I discovered this while debugging the texture test (which worked without the framebuffer unbinding). PR to servo/servo incoming too.
webgl: Fix texturing
webgl: Fix pending changes from rebase
webgl: Missing WebGL implementation details post-rebase
Document the public api While working with the API, i couldn't help but notice the lack of documentation. I talked with @glennw on IRC and he explained me a lot of details which i wrote down, so that new contributors will learn from my mistakes. I also tried to explain the relationship between the different parts of the API. It's still a bit rough but it's something. There's an equivalent PR for webrender as well.
Pin ipc-channel dependency.
Use ipc-channel from crates.io.
|
@nox pcwalton would like to hold off until his optimization PR merges, sorry about that. Do we know the cause of the CI failures on this PR in the meantime? |
|
|
|
|
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 18, 2016
Combine webrender_traits and webrender <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/330) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedAug 6, 2016
•
edited by larsbergstrom
This change is