Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine webrender_traits and webrender #330

Merged
merged 165 commits into from Aug 18, 2016
Merged

Combine webrender_traits and webrender #330

merged 165 commits into from Aug 18, 2016

Conversation

@nox
Copy link
Member

nox commented Aug 6, 2016

This change is Reviewable

gw3583 and others added 30 commits Nov 9, 2015
Switch to using ipc-channel.
Support native fonts again post-e10s.
Move all the common WebGL code to webrender_traits
I discovered this while debugging the texture test (which worked without
the framebuffer unbinding).

PR to servo/servo incoming too.
webgl: Fix pending changes from rebase
webgl: Missing WebGL implementation details post-rebase
bors-servo and others added 5 commits Aug 1, 2016
Document the public api

While working with the API, i couldn't help but notice the lack of documentation. I talked with @glennw on IRC and he explained me a lot of details which i wrote down, so that new contributors will learn from my mistakes. I also tried to explain the relationship between the different parts of the API.

It's still a bit rough but it's something.
There's an equivalent PR for webrender as well.
Pin ipc-channel dependency.
Use ipc-channel from crates.io.
@nox nox force-pushed the nox:merge branch 2 times, most recently from 4852709 to 19535e5 Aug 6, 2016
@glennw
Copy link
Member

glennw commented Aug 8, 2016

@nox This looks good to me (and thanks for doing it!) but let's just check with @pcwalton if he wants to hold off on this until the optimizations PR he is working on is ready to go.

@glennw
Copy link
Member

glennw commented Aug 8, 2016

@nox pcwalton would like to hold off until his optimization PR merges, sorry about that. Do we know the cause of the CI failures on this PR in the meantime?

@bors-servo
Copy link
Contributor

bors-servo commented Aug 8, 2016

The latest upstream changes (presumably #331) made this pull request unmergeable. Please resolve the merge conflicts.

@nox nox force-pushed the nox:merge branch from 19535e5 to 832df0c Aug 17, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2016

The latest upstream changes (presumably #344) made this pull request unmergeable. Please resolve the merge conflicts.

@nox nox force-pushed the nox:merge branch from 832df0c to a741afd Aug 18, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 18, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

📌 Commit cf3966b has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

Test exempted - status

@bors-servo bors-servo merged commit cf3966b into servo:master Aug 18, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
bors-servo added a commit that referenced this pull request Aug 18, 2016
Combine webrender_traits and webrender

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/330)
<!-- Reviewable:end -->
@nox nox deleted the nox:merge branch Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.