Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Add spatial clustering to pictures. #3309
Closed
Conversation
This improves performance by reducing the amount of per-primitive work that is required each frame. It also groups primitives that are near each other, which will be helpful for efficiently determining which parts of a cached picture are valid.
|
This is a [WIP] for now, because:
I'll investigate these tomorrow, but posting for now in case anyone has comments on the general approach. |
|
@pcwalton Not a big deal, but seeing this on CI:
Would it be possible to get pathfinder_partitioner updated to use the newer bit-vec and published? |
|
@gw3583 On it. |
|
Closing in favor of landing this in parts, starting with #3313. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gw3583 commentedNov 14, 2018
•
edited by larsbergstrom
This improves performance by reducing the amount of per-primitive
work that is required each frame. It also groups primitives that
are near each other, which will be helpful for efficiently
determining which parts of a cached picture are valid.
This change is