Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add spatial clustering to pictures. #3309

Closed
wants to merge 1 commit into from
Closed

Conversation

@gw3583
Copy link
Collaborator

gw3583 commented Nov 14, 2018

This improves performance by reducing the amount of per-primitive
work that is required each frame. It also groups primitives that
are near each other, which will be helpful for efficiently
determining which parts of a cached picture are valid.


This change is Reviewable

This improves performance by reducing the amount of per-primitive
work that is required each frame. It also groups primitives that
are near each other, which will be helpful for efficiently
determining which parts of a cached picture are valid.
@gw3583
Copy link
Collaborator Author

gw3583 commented Nov 14, 2018

This is a [WIP] for now, because:

  • There are a couple of test failures on try.
  • It (very slightly) regresses performance on dl_mutate on talos, which is far from ideal!

I'll investigate these tomorrow, but posting for now in case anyone has comments on the general approach.

@gw3583
Copy link
Collaborator Author

gw3583 commented Nov 14, 2018

@pcwalton Not a big deal, but seeing this on CI:

./Cargo.lock:1: duplicate versions for package `bit-vec`
	The following packages depend on version 0.4.4 from 'crates.io':
		pathfinder_partitioner
	The following packages depend on version 0.5.0 from 'crates.io':
		webrender

Would it be possible to get pathfinder_partitioner updated to use the newer bit-vec and published?

@pcwalton
Copy link
Collaborator

pcwalton commented Nov 14, 2018

@gw3583 On it.

@pcwalton
Copy link
Collaborator

pcwalton commented Nov 14, 2018

@gw3583
Copy link
Collaborator Author

gw3583 commented Nov 15, 2018

Closing in favor of landing this in parts, starting with #3313.

@gw3583 gw3583 closed this Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.