Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rgba as bgra_format_external on gles if bgra is not supported #3314

Merged
merged 1 commit into from Nov 16, 2018

Commits on Nov 15, 2018

  1. Use rgba as bgra_format_external on gles if bgra is not supported

    Fixes #3312.
    
    If BGRA is not supported then we use RGBA as the internal texture
    format. Since GLES is not able to swizzle texture data during upload,
    we used to also pretend the external format was RGBA in this
    case. This resulted in the red and blue channels appearing swapped,
    but was better than not working at all.
    
    This workaround got lost, however. And then an assertion was added to
    prevent us from trying to swizzle during upload on GLES. This change
    removes that assertion, and instead reinstates the workaround of
    using RGBA as the external format. This means that on GLES devices
    without BGRA support (such as the android emulator) red and blue will
    once again appear swapped, but will otherwise work.
    jamienicol committed Nov 15, 2018
You can’t perform that action at this time.