New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug checks for some global GL states. #3318

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@nical
Collaborator

nical commented Nov 16, 2018

Some simple checks to avoid confusion such as #3262. It doesn't hurt to be more explicit about the state we expect.


This change is Reviewable

@nical

This comment has been minimized.

Collaborator

nical commented Nov 16, 2018

r? @kvark

@kvark

This comment has been minimized.

Member

kvark commented Nov 16, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 16, 2018

📌 Commit 3965df8 has been approved by kvark

bors-servo added a commit that referenced this pull request Nov 16, 2018

Auto merge of #3318 - nical:gl-state-check, r=kvark
Add debug checks for some global GL states.

Some simple checks to avoid confusion such as #3262. It doesn't hurt to be more explicit about the state we expect.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3318)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 16, 2018

⌛️ Testing commit 3965df8 with merge 596984d...

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 16, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 596984d to master...

@bors-servo bors-servo merged commit 3965df8 into servo:master Nov 16, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment