Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct inner radii for the border #333

Merged
merged 1 commit into from Aug 10, 2016
Merged

Correct inner radii for the border #333

merged 1 commit into from Aug 10, 2016

Conversation

@msreckovic
Copy link
Contributor

msreckovic commented Aug 9, 2016

Inner radius values in X are wrong - they are using the values from X direction instead.

  • [ X] ./mach build -d does not report any errors
  • [X ] ./mach test-tidy does not report any errors
  • [X ] There are tests for these changes (the errors are masked until we implement elliptical corners)

This change is Reviewable

Inner radius values in X are wrong - they are using the values from X direction instead.
@glennw
Copy link
Member

glennw commented Aug 9, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2016

📌 Commit 98f72ae has been approved by glennw

@bors-servo
Copy link
Contributor

bors-servo commented Aug 9, 2016

Testing commit 98f72ae with merge 0c9cc21...

bors-servo added a commit that referenced this pull request Aug 9, 2016
Correct inner radii for the border

Inner radius values in X are wrong - they are using the values from X direction instead.
- [ X] `./mach build -d` does not report any errors
- [X ] `./mach test-tidy` does not report any errors

- [X ] There are tests for these changes (the errors are masked until we implement elliptical corners)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/333)
<!-- Reviewable:end -->
@glennw
Copy link
Member

glennw commented Aug 9, 2016

Thanks!

@emilio
Copy link
Member

emilio commented Aug 10, 2016

@emilio emilio merged commit 891ce27 into servo:master Aug 10, 2016
2 of 3 checks passed
2 of 3 checks passed
homu Testing commit 98f72ae with merge 0c9cc21...
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@msreckovic msreckovic deleted the msreckovic:patch-1 branch Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.