Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple RGBA8 support #3337

Merged
merged 1 commit into from Nov 27, 2018
Merged

Add simple RGBA8 support #3337

merged 1 commit into from Nov 27, 2018

Conversation

@sotaroikeda
Copy link
Contributor

sotaroikeda commented Nov 22, 2018

Current Linux with Wayland causes crash when WebGL exists. By Bug 1482350 Comment 15, WebRender needs to support RGBA8.

This is a simple quick fix for supporting RGBA8.

See Bug 1482350


This change is Reviewable

@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Nov 23, 2018

r? anyone

@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Nov 27, 2018

@nical, can you review it?

@nical
Copy link
Collaborator

nical commented Nov 27, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

📌 Commit 102663b has been approved by nical

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

Testing commit 102663b with merge 195582a...

bors-servo added a commit that referenced this pull request Nov 27, 2018
Add simple RGBA8 support

Current Linux with Wayland causes crash when WebGL exists. By [Bug 1482350 Comment 15](https://bugzilla.mozilla.org/show_bug.cgi?id=1482350#c15), WebRender needs to support RGBA8.

This is a simple quick fix for supporting RGBA8.

See [Bug 1482350](https://bugzilla.mozilla.org/show_bug.cgi?id=1482350)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3337)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 195582a to master...

@bors-servo bors-servo merged commit 102663b into servo:master Nov 27, 2018
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@sotaroikeda
Copy link
Contributor Author

sotaroikeda commented Nov 27, 2018

Thanks!

@sotaroikeda sotaroikeda deleted the sotaroikeda:rgba branch Nov 27, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 27, 2018
…60ccc8f423d8 (WR PR #3337). r=kats

servo/webrender#3337

Differential Revision: https://phabricator.services.mozilla.com/D13111

--HG--
extra : moz-landing-system : lando
jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Nov 28, 2018
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…60ccc8f423d8 (WR PR #3337). r=kats

servo/webrender#3337

Differential Revision: https://phabricator.services.mozilla.com/D13111

UltraBlame original commit: f1f219c67ea86f83b400cf1f55cf61f2192afe5e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…60ccc8f423d8 (WR PR #3337). r=kats

servo/webrender#3337

Differential Revision: https://phabricator.services.mozilla.com/D13111

UltraBlame original commit: f1f219c67ea86f83b400cf1f55cf61f2192afe5e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…60ccc8f423d8 (WR PR #3337). r=kats

servo/webrender#3337

Differential Revision: https://phabricator.services.mozilla.com/D13111

UltraBlame original commit: f1f219c67ea86f83b400cf1f55cf61f2192afe5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.