New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default deserializer for frame_id #3339

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
3 participants
@kvark
Member

kvark commented Nov 22, 2018

Since frame ID is debug-only, it's not serialized when capturing from a release-built Firefox, making us unable to replay it with debug Wrench. This PR fixes this (broken recently by #3289).

r? anyone


This change is Reviewable

@kvark kvark requested a review from gw3583 Nov 22, 2018

@emilio

This comment has been minimized.

Member

emilio commented Nov 22, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 22, 2018

📌 Commit 807dcd8 has been approved by emilio

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 22, 2018

⌛️ Testing commit 807dcd8 with merge 362eea0...

bors-servo added a commit that referenced this pull request Nov 22, 2018

Auto merge of #3339 - servo:kvark-frame-id, r=emilio
Add default deserializer for frame_id

Since frame ID is debug-only, it's not serialized when capturing from a release-built Firefox, making us unable to replay it with debug Wrench. This PR fixes this (broken recently by #3289).

r? anyone

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3339)
<!-- Reviewable:end -->

@kvark kvark force-pushed the kvark-frame-id branch from 807dcd8 to 265116c Nov 22, 2018

@kvark

This comment has been minimized.

Member

kvark commented Nov 22, 2018

oops, gotta gate for replay feature
@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 22, 2018

📌 Commit 265116c has been approved by emilio

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 22, 2018

⌛️ Testing commit 265116c with merge 1ad9b79...

bors-servo added a commit that referenced this pull request Nov 22, 2018

Auto merge of #3339 - servo:kvark-frame-id, r=emilio
Add default deserializer for frame_id

Since frame ID is debug-only, it's not serialized when capturing from a release-built Firefox, making us unable to replay it with debug Wrench. This PR fixes this (broken recently by #3289).

r? anyone

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3339)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 22, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: emilio
Pushing 1ad9b79 to master...

@bors-servo bors-servo merged commit 265116c into master Nov 22, 2018

5 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Taskcluster (push) TaskGroup: success
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@kvark kvark deleted the kvark-frame-id branch Nov 23, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 23, 2018

WR Updater Bot
Bug 1509365 - Update webrender to commit 1ad9b79c3d19dec310077206002d…
…09f5c7fb14cd (WR PR #3339). r=kats

servo/webrender#3339

Differential Revision: https://phabricator.services.mozilla.com/D12751

--HG--
extra : moz-landing-system : lando

jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Nov 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment