New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for capturing tiled images #3344

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@kvark
Member

kvark commented Nov 23, 2018

Related (but doesn't completely fix) to #2236
Only ones that actually take a single tile are supported atm, and we also try not to crash on others. This is strictly an improvement over the current behavior (that just panics).

r? anyone


This change is Reviewable

@kvark kvark requested a review from nical Nov 23, 2018

@nical

This comment has been minimized.

Collaborator

nical commented Nov 23, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 23, 2018

📌 Commit 32b1f94 has been approved by nical

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 23, 2018

🔒 Merge conflict

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 23, 2018

☔️ The latest upstream changes (presumably #3277) made this pull request unmergeable. Please resolve the merge conflicts.

@kvark kvark force-pushed the kvark:capture-tile branch from 32b1f94 to ca3ac2a Nov 23, 2018

@kvark

This comment has been minimized.

Member

kvark commented Nov 23, 2018

rebased
@bors-servo r=nical

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 23, 2018

📌 Commit ca3ac2a has been approved by nical

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 23, 2018

⌛️ Testing commit ca3ac2a with merge 7051f18...

bors-servo added a commit that referenced this pull request Nov 23, 2018

Auto merge of #3344 - kvark:capture-tile, r=nical
Basic support for capturing tiled images

Related (but doesn't completely fix) to #2236
Only ones that actually take a single tile are supported atm, and we also try not to crash on others. This is strictly an improvement over the current behavior (that just panics).

r? anyone

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3344)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 23, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: nical
Pushing 7051f18 to master...

@bors-servo bors-servo merged commit ca3ac2a into servo:master Nov 23, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@kvark kvark deleted the kvark:capture-tile branch Nov 23, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 24, 2018

WR Updater Bot
Bug 1509592 - Update webrender to commit 7051f18fdcfbe60ecdbaeaa8e53c…
…4ba98f2037a1 (WR PR #3344). r=kats

servo/webrender#3344

Differential Revision: https://phabricator.services.mozilla.com/D12822

--HG--
extra : moz-landing-system : lando

jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Nov 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment