Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd primitive interning for YUV images. #3349
Conversation
|
r? @kvark or anyone This includes #3348 and #3346 - it might be easier to review this after those land. Pending try: |
Also restructure and tidy up some of the code that handles segment building + interned primitives. This reduces some of the code duplication and will simplify porting the remaining primitives to interning.
|
Rebased this on top of the recent patches that have landed, so there is just one commit here now. |
webrender/src/prim_store.rs, line 553 at r1 (raw file):
similarly, it's unfortunate that this is duplicated with webrender/src/prim_store.rs, line 3214 at r1 (raw file):
do we really need the |
|
@bors-servo r+ |
|
|
Add primitive interning for YUV images. Also restructure and tidy up some of the code that handles segment building + interned primitives. This reduces some of the code duplication and will simplify porting the remaining primitives to interning. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3349) <!-- Reviewable:end -->
|
|
…4c3a7e6cb31d (WR PR #3349). r=kats servo/webrender#3349 Differential Revision: https://phabricator.services.mozilla.com/D13030 --HG-- extra : moz-landing-system : lando
…4c3a7e6cb31d (WR PR #3349). r=kats servo/webrender#3349 Differential Revision: https://phabricator.services.mozilla.com/D13030
gw3583 commentedNov 24, 2018
•
edited by larsbergstrom
Also restructure and tidy up some of the code that handles
segment building + interned primitives. This reduces some of
the code duplication and will simplify porting the remaining
primitives to interning.
This change is