New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port radial gradients to interning, remove all legacy prim structures. #3353

Merged
merged 3 commits into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Collaborator

gw3583 commented Nov 26, 2018

This ports the last legacy primitive to be interned (radial gradients), and removes all old primitive structures. It also removes PrimitiveContainer, which is no longer needed.


This change is Reviewable

@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Nov 26, 2018

r? @kvark or anyone else.

Thus completes the conversion of all primitives to interning, which gives us a stable unique ID for primitives based on content.

This patch set is huge, and I apologize to anyone reviewing it. It's mostly shuffling code around, and also includes the patches in #3349, #3350, #3352, which can be reviewed separately, if easier.

@gw3583

This comment has been minimized.

@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Nov 26, 2018

Try run looks good so far, and a small gain in dl_mutate, which is a bonus.

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 26, 2018

☔️ The latest upstream changes (presumably #3349) made this pull request unmergeable. Please resolve the merge conflicts.

@kvark

Try run looks good so far, and a small gain in dl_mutate, which is a bonus.

I thought we'd see better gains here for removing a bunch of memcopies for things like PrimitiveContainer?

Anyhow, amazing work, and exciting to see this change getting finished! 🎉

Reviewed 5 of 8 files at r5, 5 of 5 files at r6.
Reviewable status: 10 of 13 files reviewed, all discussions resolved

@gw3583 gw3583 force-pushed the gw3583:intern-last-2 branch 2 times, most recently from 031033e to df7e8cb Nov 26, 2018

@gw3583 gw3583 force-pushed the gw3583:intern-last-2 branch from df7e8cb to 5f88090 Nov 27, 2018

@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Nov 27, 2018

@bors-servo r=kvark (via IRC).

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 27, 2018

📌 Commit 5f88090 has been approved by kvark

bors-servo added a commit that referenced this pull request Nov 27, 2018

Auto merge of #3353 - gw3583:intern-last-2, r=kvark
Port radial gradients to interning, remove all legacy prim structures.

This ports the last legacy primitive to be interned (radial gradients), and removes all old primitive structures. It also removes PrimitiveContainer, which is no longer needed.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3353)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 27, 2018

⌛️ Testing commit 5f88090 with merge ea8f4a9...

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 27, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing ea8f4a9 to master...

@bors-servo bors-servo merged commit 5f88090 into servo:master Nov 27, 2018

3 of 4 checks passed

code-review/reviewable 11 files left (kvark)
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 27, 2018

WR Updater Bot
Bug 1510222 - Update webrender to commit ea8f4a922b2aa38c40de137d7f0a…
…b6598d53e29a (WR PR #3353). r=kats

servo/webrender#3353

Differential Revision: https://phabricator.services.mozilla.com/D13057

--HG--
extra : moz-landing-system : lando

jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment