Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port radial gradients to interning, remove all legacy prim structures. #3353

Merged
merged 3 commits into from Nov 27, 2018
Merged

Port radial gradients to interning, remove all legacy prim structures. #3353

merged 3 commits into from Nov 27, 2018
+474 −833

Conversation

@gw3583
Copy link
Collaborator

gw3583 commented Nov 26, 2018 •
edited by larsbergstrom

This ports the last legacy primitive to be interned (radial gradients), and removes all old primitive structures. It also removes PrimitiveContainer, which is no longer needed.

This change is Reviewable
@gw3583
Copy link
Collaborator Author

gw3583 commented Nov 26, 2018

r? @kvark or anyone else.

Thus completes the conversion of all primitives to interning, which gives us a stable unique ID for primitives based on content.

This patch set is huge, and I apologize to anyone reviewing it. It's mostly shuffling code around, and also includes the patches in #3349, #3350, #3352, which can be reviewed separately, if easier.
@gw3583
Copy link
Collaborator Author

gw3583 commented Nov 26, 2018

Pending try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=218615242ebba06de5d4e6fbb6045546808cf806
@gw3583
Copy link
Collaborator Author

gw3583 commented Nov 26, 2018

Try run looks good so far, and a small gain in dl_mutate, which is a bonus.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2018

☔ The latest upstream changes (presumably #3349) made this pull request unmergeable. Please resolve the merge conflicts.
@kvark
kvark reviewed Nov 26, 2018
View changes
Copy link
Member

kvark left a comment

Try run looks good so far, and a small gain in dl_mutate, which is a bonus.

I thought we'd see better gains here for removing a bunch of memcopies for things like PrimitiveContainer?

Anyhow, amazing work, and exciting to see this change getting finished! 🎉

Reviewed 5 of 8 files at r5, 5 of 5 files at r6.
Reviewable status: 10 of 13 files reviewed, all discussions resolved
@gw3583 gw3583 force-pushed the gw3583:intern-last-2 branch 2 times, most recently from 031033e to df7e8cb Nov 26, 2018
gw3583 added 3 commits Nov 26, 2018
@gw3583
Port radial gradients to be interned primitives.
ec129d9
@gw3583
Remove old legacy style primitive code.
f97480c
@gw3583
Remove PrimitiveContainer
Loading status checks…
5f88090
@gw3583 gw3583 force-pushed the gw3583:intern-last-2 branch from df7e8cb to 5f88090 Nov 27, 2018
@gw3583
Copy link
Collaborator Author

gw3583 commented Nov 27, 2018

@bors-servo r=kvark (via IRC).
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

📌 Commit 5f88090 has been approved by kvark
bors-servo added a commit that referenced this pull request Nov 27, 2018
@bors-servo
Auto merge of #3353 - gw3583:intern-last-2, r=kvark
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ea8f4a9 
Port radial gradients to interning, remove all legacy prim structures.

This ports the last legacy primitive to be interned (radial gradients), and removes all old primitive structures. It also removes PrimitiveContainer, which is no longer needed.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3353)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

⌛ Testing commit 5f88090 with merge ea8f4a9...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing ea8f4a9 to master...
@bors-servo bors-servo merged commit 5f88090 into servo:master Nov 27, 2018
3 of 4 checks passed
3 of 4 checks passed
code-review/reviewable 11 files left (kvark)
Details
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 27, 2018
@moz-gfx
Bug 1510222 - Update webrender to commit ea8f4a922b2aa38c40de137d7f0a…
3200c58 
…b6598d53e29a (WR PR #3353). r=kats

servo/webrender#3353

Differential Revision: https://phabricator.services.mozilla.com/D13057

--HG--
extra : moz-landing-system : lando
jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Nov 27, 2018
@moz-gfx
Bug 1510222 - Update webrender to commit ea8f4a922b2aa38c40de137d7f0a…
be685e4 
…b6598d53e29a (WR PR #3353). r=kats

servo/webrender#3353

Differential Revision: https://phabricator.services.mozilla.com/D13057
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
@marco-c
Bug 1510222 - Update webrender to commit ea8f4a922b2aa38c40de137d7f0a…
93c78da 
…b6598d53e29a (WR PR #3353). r=kats

servo/webrender#3353

Differential Revision: https://phabricator.services.mozilla.com/D13057

UltraBlame original commit: c779bf180e26500b0a907c55f992be2121fc4ee9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1510222 - Update webrender to commit ea8f4a922b2aa38c40de137d7f0a…
2a72116 
…b6598d53e29a (WR PR #3353). r=kats

servo/webrender#3353

Differential Revision: https://phabricator.services.mozilla.com/D13057

UltraBlame original commit: c779bf180e26500b0a907c55f992be2121fc4ee9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1510222 - Update webrender to commit ea8f4a922b2aa38c40de137d7f0a…
60561dd 
…b6598d53e29a (WR PR #3353). r=kats

servo/webrender#3353

Differential Revision: https://phabricator.services.mozilla.com/D13057

UltraBlame original commit: c779bf180e26500b0a907c55f992be2121fc4ee9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@gw3583 @bors-servo @kvark
You can’t perform that action at this time.